Skip to content

Disable inline parameter hints when CustomOperation attribute is detected #14517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Disable inline parameter hints when CustomOperation attribute is detected #14517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5baff00
disable inline parameter hints for custom operations
rosskuehl Dec 28, 2022
b999155
Merge branch 'main' into task/disable-inline-parameter-hints-when-cus…
rosskuehl Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vsintegration/src/FSharp.Editor/Hints/InlineParameterNameHints.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ module InlineParameterNameHints =
symbol.DeclaringEntity
|> Option.exists (fun entity -> entity.CompiledName <> "Operators")

let isNotCustomOperation =
not <| symbol.HasAttribute<CustomOperationAttribute>()

(symbol.IsFunction && isNotBuiltInOperator) // arguably, hints for those would be rather useless
|| symbol.IsConstructor
|| symbol.IsMethod
|| (symbol.IsMethod && isNotCustomOperation)
else
false

Expand Down
15 changes: 14 additions & 1 deletion vsintegration/tests/FSharp.Editor.Tests/Hints/InlineParameterNameHintTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,4 +478,17 @@ let test sequences =

let actual = getParameterNameHints document

Assert.AreEqual(expected, actual)
Assert.AreEqual(expected, actual)

[<Test>]
let ``Hints are not shown when CustomOperation attribute is detected`` () =
let code =
"""
let q = query { for x in { 1 .. 10 } do select x }
"""

let document = getFsDocument code

let actual = getParameterNameHints document

Assert.IsEmpty actual