-
Notifications
You must be signed in to change notification settings - Fork 833
Not constructor arguments are allowed in static classes #14512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not constructor arguments are allowed in static classes #14512
Conversation
|
@T-Gro Any idea why the CI is failing ? . It seem to be related to my changes but Im failing to understand why :( |
…lasses' of https://github.com/edgarfgp/fsharp into compiler-warning-when-constructor-arguments-in-static-classes
Will have a look |
Made a few pushes already:
|
…solution is not production ready
|
@edgarfgp Check the current code and commit log.
We can chat on Slack if you want to discuss this |
Thanks @T-Gro :) . |
|
@T-Gro I found a later phase to do the attribute checking (Thanks for your help). Now that the CI is happy, I wanted to double-check if that error message and the ranges are clear enough. Any feedback is welcome :) |
|
Left a suggestion. I would rather avoid putting verbs (are,is,..) into in and want to have them as part of the template, because different languages have different word order rules as well as negation rules. As long as it is the template, translator can change both the sentence as well as placement of the '%s' expression. |
|
As discussed on slack, we should probably use different errors for each case, as oppose to having one interpolated (which won't go well with localizations). |
|
@vzarytovskii Updated as discussed in Slack :) |
…in-static-classes
…in-static-classes
|
@0101 by Any chance I have another review and hopefully merge it? So I can continue adding errors on static classes? |
0101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But I think we should fix the capitalization in the error messages.
Co-authored-by: Petr Pokorny <[email protected]>
…in-static-classes
Fixes one the multiple missing error reporting in #13147
This PR adds:
[<Sealed; AbstractClass>]I will adding more error reporting in the future :)