-
Notifications
You must be signed in to change notification settings - Fork 832
Reducing compiler directives (NETSTANDARD) #14510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
/run fantomas |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@KevinRansom : When changing runtimeRoot (from typeof.Assembly.Location to GetRuntimeDirectory() ), a test for FSI /usesdkrefs**-** starts failing with: Error creating evaluation session: System.AggregateException: One or more errors occurred. (Assembly: The system type 'System.Array' was required but no referenced system DLL contained this type, full path: System.Array) |
@KevinRansom : Funnily, there was a bug related to trimming separators which only revealed itself after doing this change. |
…g combinatiorial test into <inlinedata>
…m/dotnet/fsharp into reducing-compiler-directive-usage
Eliminate usage of NETSTANDARD compiler directives for main libraries where we have target frameworks netstandard(20/21) only => NETSTANDARD was defined in both cases, so the compiler always took only 1 branch of the #if .
Reduce usage of NETSTANDARD conditionals in tests where needed.
Encapsulate #if - then #else pattern for tests that have been: