-
Notifications
You must be signed in to change notification settings - Fork 832
Add FsharpType.MakeStructTupleType overload that does not accept an assembly #14504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FsharpType.MakeStructTupleType overload that does not accept an assembly #14504
Conversation
…load-that-does-not-accept-an-assembly
|
Since it's a breaking change (existing method is getting |
Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
…load-that-does-not-accept-an-assembly
|
Just curious, the change makes total sense, but is there a tracking issue or is this just general cleanup? Since we stopped updating the changelog (I’d love to have that back, but that’s OT), in particular with backward compat issues, having a tracking issue would be nice. |
Only this: |
|
You meant a tracking issue for all API-relevant-changes to be linked into, right? |
|
Yes, that’s what I meant. Usually it’s referenced in the PR description if there is one (and afaik, you usually link it), hence me wondering ;). |
Understood, just not seeing an appropriate one. |
|
Actually, I just meant linking #14398. But you’re right, a tracking issue to list API changes is something we’ve used in the past and would be really useful. |
|
Deprecation via |
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff thanks.
…load-that-does-not-accept-an-assembly
…load-that-does-not-accept-an-assembly
…load-that-does-not-accept-an-assembly
…load-that-does-not-accept-an-assembly
Addresses #14398
Make a new FsharpType.MakeStructTupleType overload that does not accept an assembly argument
Obsolete existing members in reflection and quotations that still need it
Change the inner implementation to be lock-free and work with netstandard ref-tuples and struct-tuples
Add new tests (e.g. for 'tuple nesting' behaviour)
Inner workings of Obsolete code moved to a separate module, to make them easy to delete once API surface can be reduced