Prevent IDE crash in case of file duplicate in fsproj #14496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent IDE error in the first place - Report diagnostics in case of fsc.exe build - Report warning in case of service build - Fix bug in componenttest framework for .fsi compilation
vzarytovskii
previously approved these changes
Dec 20, 2022
0101
previously approved these changes
Dec 20, 2022
tests/FSharp.Compiler.ComponentTests/EmittedIL/Structure/UnionTypeWithSignature02.fs
Show resolved
Hide resolved
Member
Author
|
CompilerOptions\fsc*gccerrors* (1) -- failed ;; will check it. |
0101
approved these changes
Dec 27, 2022
vzarytovskii
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same file was listed twice for compilation (typically = text-based merge conflict resolution), the following happened:
There was no obvious clue about the real error coming from a different project.
Since regular build worked, the error creation went trough CI just fine and it only started to make troubles in IDE scenarios (= days later, different users of the project).
The following has been done:
Evidence:
