Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @0101,
In light of #14479, I worked on a little experiment to see what collecting the identifiers from AST would look like.
On the same machine #14479 gave:
so the results are very similar.
The AST traversal code could be improved a bit. I wouldn't claim it is fully tail-recursive 🙈.
Overall, I think this is a bit cleaner in terms of the data the syntax tree carries.