-
Notifications
You must be signed in to change notification settings - Fork 831
Making inline type hints less intrusive #14386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @kerams for the suggestions btw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the property is part of public surface API, it's a breaking change, then we will either need to bump major FCS version, or leave old one, mark it as obsolete and suggest using new one .
Also, how does it work with SRTP, iwsams generic functions and methods? What does it display?
Mhm I'm allergic to typos but alright let's revert the breaking change and then solve it separately
Will check it and add some extra tests maybe, stay tuned. |
Understandable, but we should start being more careful with breaking changes in minor versions, it's a big pain point for community tooling |
|
So @vzarytovskii IWSAM is working correctly (added a test), SRTP has a small issue, will deal with it separately here. |
Partially fixes #14382
Fixes: #14393
Before:
2022-11-24.16-54-11.mp4
After:
2022-11-24.16-57-40.mp4
I found this nearly unused properly which seems to do the trick.
Note this does not solve the issue completely:
2022-11-24.17-00-50.mp4