Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 24, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: d1dd3c14-f8e9-46f4-7fb7-08d8446de174
  • Build: 20221128.1
  • Date Produced: November 28, 2022 10:22:58 AM UTC
  • Commit: 3817f2b38a05c37c950715f84c95d452bcacfe52
  • Branch: refs/heads/main

…122.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22572.5
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner November 24, 2022 13:02
T-Gro
T-Gro previously approved these changes Nov 24, 2022
@vzarytovskii
Copy link
Member

We're getting a bunch of

error NETSDK1192: Targeting .NET 7.0 or higher in Visual Studio 2022 17.3 is not supported.

On most of our windows CI legs.

@MattGal does this ring a bell? Do we need to update images we're running on or something?

…124.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22574.1
dotnet-maestro bot and others added 2 commits November 26, 2022 13:02
…125.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22575.1
@MattGal
Copy link
Member

MattGal commented Nov 28, 2022

@MattGal does this ring a bell? Do we need to update images we're running on or something?

Not sure, but I definitely touched the default xcopy msbuild version here so I'll take an initial stab at investigation.

@MattGal
Copy link
Member

MattGal commented Nov 28, 2022

@vzarytovskii I think this is a little convoluted due to the complexities of your build. I did verify you're just using the msbuild that comes with the VS install, so this isn't an xcopy-msbuild problem. I think this can be fixed by temporarily setting your pipeline variable for the image used in CI to windows.vs2022.scout.amd64.open, but this will be global for all runs so I didn't just set it; if you'd like me to set it and retry I can:

image

The windows.vs2022.scout.amd64.open image is already at 17.4.0 which should make your error message go away, and you can flip back when that becomes the "main" VS 2022 image, which should be around 12/7/2022.

@vzarytovskii
Copy link
Member

Yeah, I think it's fine to set it for now for all runs, we would like to start testing compiler on the 7.0.100

@MattGal
Copy link
Member

MattGal commented Nov 28, 2022

Yeah, I think it's fine to set it for now for all runs, we would like to start testing compiler on the 7.0.100

Flipped it over and hit retry. Due to the way variables work there's a chance you may need to close and reopen the PR to pick up the change.

@MattGal
Copy link
Member

MattGal commented Nov 28, 2022

Yeah, I think it's fine to set it for now for all runs, we would like to start testing compiler on the 7.0.100

Flipped it over and hit retry. Due to the way variables work there's a chance you may need to close and reopen the PR to pick up the change.

@vzarytovskii please close/reopen at your leisure, I can't and it didn't pick up the new queue as expected.

vzarytovskii and others added 2 commits November 28, 2022 18:27
This test is failing in CI for some reason. But we don't really care about what it tests anyway - having private values in signature files, in which there's really no point
@0101 0101 mentioned this pull request Nov 29, 2022
0101 and others added 2 commits November 29, 2022 12:36
…128.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22578.1
@vzarytovskii vzarytovskii enabled auto-merge (squash) November 29, 2022 15:04
@vzarytovskii vzarytovskii merged commit 6df0bab into main Nov 29, 2022
@vzarytovskii vzarytovskii deleted the darc-main-cd562447-3372-4757-91e7-a0a627481a1b branch November 29, 2022 15:06
@vzarytovskii
Copy link
Member

Signed builds are broken, I'm going to revert it

@MattGal
Copy link
Member

MattGal commented Nov 30, 2022

Signed builds are broken, I'm going to revert it

It's the same as the public build hit. We'll have 17.4 soon, just having trouble with rollouts this morning.

@vzarytovskii
Copy link
Member

Signed builds are broken, I'm going to revert it

It's the same as the public build hit. We'll have 17.4 soon, just having trouble with rollouts this morning.

Sure, just wanted to unblock us from inserting. Going to re-do the PR once images rollout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants