Fix 14340 - Prompt issues between VS and fsi. #14383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
approved these changes
Nov 23, 2022
T-Gro
reviewed
Nov 23, 2022
T-Gro
reviewed
Nov 23, 2022
T-Gro
previously approved these changes
Nov 23, 2022
abonie
previously approved these changes
Nov 25, 2022
abonie
previously approved these changes
Nov 28, 2022
T-Gro
previously approved these changes
Nov 28, 2022
0101
previously approved these changes
Nov 30, 2022
Co-authored-by: Petr Pokorny <[email protected]>
vzarytovskii
dismissed stale reviews from 0101, T-Gro, and abonie
via
f293204
abonie
approved these changes
Nov 30, 2022
0101
approved these changes
Nov 30, 2022
vzarytovskii
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because fsi, displays prompts, even when executing code sent from vsfsi. When code is sent to fsi for execution VSFSI, adds additional code in the form of directives, and extra ";;" in order to get FSI to display errors with file and line numbers matching the .fsx file being edited.
Because of the way the repl loop works in fsi, it was not possible to figure out how to eliminate prompt display based on whether we are interactive or executing snippets. Instead, I added a new directive to control the prompt:
#interactiveprompt "show" | "hide" | "skip"
"show" enables the prompt to be displayed when fsi needs it to.
"hide" ensures that the prompt will not show.
"skip" hides the prompt for the next time vs wants to show it.
Then I added:
#interactiveprompt "hide"
and
#interactiveprompt "show"
into the additional directives that are sent to the fsi process.
Todo:
Add some tests for
#interactiveprompt "show" | "hide" | "skip"