Fix some bugs on FSI.exe #14365
Merged
Fix some bugs on FSI.exe #14365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix FSI's display error on multiple-line input
|
|
T-Gro
reviewed
Nov 21, 2022
T-Gro
reviewed
Nov 21, 2022
make fullWidthCharRanges more like a ranges array
T-Gro
previously approved these changes
Nov 24, 2022
0101
reviewed
Nov 24, 2022
Contributor
0101
left a comment
0101
left a comment
There was a problem hiding this comment.
Is it possible to add some tests for this new behavior?
auto-merge was automatically disabled
November 25, 2022 02:10
Head branch was pushed to by a user without write access
Contributor
Author
I don't know how to test how it is displayed by terminal ... |
T-Gro
approved these changes
Dec 9, 2022
psfinaki
approved these changes
Dec 12, 2022
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Mhmh yeah we should create a proper testing framework for this, piping the output to a file or something. Not in the scope of this PR, just thinking out loud.
@Tangent-90 thanks for the contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
before:
after:
