Don't crash when looking up XML docs for signature with apostrophe #14311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
previously approved these changes
Nov 14, 2022
psfinaki
reviewed
Nov 15, 2022
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Any testing possible here?
Contributor
Author
|
@psfinaki there should be... actually wonder if this is covered by any tests right now. I will find out. |
This reverts commit 599a4ef.
Contributor
Author
|
@psfinaki Don't think this was tested directly (although plenty indirectly), so I added a test. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
KevinRansom
approved these changes
Nov 21, 2022
T-Gro
approved these changes
Nov 22, 2022
Contributor
|
@0101 too late to approve - but thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13817
There seems to be no good way to escape
'in XPath other than wrap the string with".For sake of simplicity and since it didn't work before anyway, I propose to not look up the docs when you have a value with both
'and"in its name (which would be a pretty strange thing to have).