Skip to content

Conversation

@kant2002
Copy link
Contributor

My older brother just join your club. I'm want to be part of the test suite too.

My older brother just join your club. I'm want to be part of the test suite too.
@kant2002 kant2002 requested a review from a team as a code owner November 13, 2022 18:51
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vzarytovskii --- can you take a look.

@T-Gro
Copy link
Member

T-Gro commented Nov 14, 2022

Mismatch in error message, expected '"The type 'float' is not compatible with the type 'ITrigonometricFunctions<float>'"' was not found during compilation

@T-Gro
Copy link
Member

T-Gro commented Nov 14, 2022

Whereas the actual error in the failing tests is:

["Error 39 "The type 'ITrigonometricFunctions' is not defined."";
"Error 3533 "Invalid constraint. Valid constraint forms include "'T :> ISomeInterface" for interface constraints and "SomeConstrainingType<'T>" for self-constraints. See https://aka.ms/fsharp-type-constraints.""]

@vzarytovskii
Copy link
Member

I'll take a look at it, we're likely just didn't use correct interfaces from bcl.

@vzarytovskii vzarytovskii added this to the November-2022 milestone Nov 14, 2022
@vzarytovskii vzarytovskii self-assigned this Nov 14, 2022
@vzarytovskii
Copy link
Member

vzarytovskii commented Nov 14, 2022

Ok, I've re-enabled those as part of #14294 last week, and fixed them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants