Inline parameter name hints for F# #14215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
requested changes
Nov 2, 2022
0101
reviewed
Nov 3, 2022
vzarytovskii
requested changes
Nov 3, 2022
Member
vzarytovskii
left a comment
vzarytovskii
left a comment
There was a problem hiding this comment.
How will it handle active patterns? Maybe worth adding some tests for them too.
vzarytovskii
reviewed
Nov 4, 2022
vzarytovskii
previously approved these changes
Nov 7, 2022
T-Gro
previously approved these changes
Nov 7, 2022
T-Gro
approved these changes
Nov 7, 2022
vzarytovskii
approved these changes
Nov 7, 2022
kerams
reviewed
Nov 8, 2022
| |> Option.exists (fun entity -> entity.CompiledName <> "Operators") | ||
|
|
||
| symbol.IsFunction | ||
| && isNotBuiltInOperator // arguably, hints for those would be rather useless |
Contributor
There was a problem hiding this comment.
I think this is missing a symbolUse.IsFromUse check, because without it function definitions are eligible for a hint, even though you will later find no applied arguments, so nothing is shown. I will fix it in the member and ctor PR.
Contributor
Author
There was a problem hiding this comment.
Right, so the behavior is by coincidence :) Yes, this will be a valid check, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14174
See the feature in action:
parameter.name.hints.mp4
Note for reviewers: new stuff is basically this, everything else is refactoring and extra testing.