Skip to content

Disallow explicit type parameters on getset properties #14212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2022
Merged

Disallow explicit type parameters on getset properties #14212

merged 3 commits into from
Nov 3, 2022

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Nov 2, 2022

Expanding on #13978, which only prevents inferring type parameters.

@kerams kerams requested a review from a team as a code owner November 2, 2022 10:00
@T-Gro T-Gro requested review from 0101 and vzarytovskii November 2, 2022 20:16
psfinaki
psfinaki approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki psfinaki merged commit d9fed81 into dotnet:main Nov 3, 2022
@kerams kerams deleted the p branch November 3, 2022 11:32
@allisonchou allisonchou mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii Awaiting requested review from vzarytovskii

@0101 0101 Awaiting requested review from 0101

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.5

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kerams @psfinaki @T-Gro @vzarytovskii