Skip to content

Use a more accurate range when reporting an error on delegate type declaration #14208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Use a more accurate range when reporting an error on delegate type declaration #14208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba22079
Use more a more accurate range when reporing an error on delegate typ…
edgarfgp Nov 1, 2022
47f496f
Merge branch 'main' into use-more-accurate-range-for-delegate-types-e…
edgarfgp Nov 2, 2022
b22529d
Merge branch 'main' into use-more-accurate-range-for-delegate-types-e…
edgarfgp Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Compiler/Checking/CheckDeclarations.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3161,7 +3161,10 @@ module EstablishTypeDefinitionCores =
| None -> ()
| Some spats ->
let ctorArgNames, _ = TcSimplePatsOfUnknownType cenv true CheckCxs envinner tpenv spats
if not ctorArgNames.IsEmpty then errorR (Error(FSComp.SR.parsOnlyClassCanTakeValueArguments(), m))
if not ctorArgNames.IsEmpty then
match spats with
| SynSimplePats.SimplePats(_, m) -> errorR (Error(FSComp.SR.parsOnlyClassCanTakeValueArguments(), m))
| SynSimplePats.Typed(_, _, m) -> errorR (Error(FSComp.SR.parsOnlyClassCanTakeValueArguments(), m))

let envinner = AddDeclaredTypars CheckForDuplicateTypars (tycon.Typars m) envinner
let envinner = MakeInnerEnvForTyconRef envinner thisTyconRef false
Expand Down
11 changes: 7 additions & 4 deletions tests/FSharp.Compiler.ComponentTests/Conformance/DelegateTypes/DelegateDefinition.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ namespace FSharpTest
"""
|> compile
|> shouldFail
|> withErrorCode 552
|> withErrorMessage "Only class types may take value arguments"
|> withDiagnostics [
(Error 552, Line 3, Col 11, Line 3, Col 19, "Only class types may take value arguments")
]

[<Fact>]
let ``Delegate definition with primary constructor no argument.`` () =
Expand All @@ -30,8 +31,10 @@ namespace FSharpTest
"""
|> compile
|> shouldFail
|> withErrorCode 552
|> withErrorMessage "Only class types may take value arguments"
|> shouldFail
|> withDiagnostics [
(Error 552, Line 3, Col 11, Line 3, Col 13, "Only class types may take value arguments")
]

[<Fact>]
let ``Delegate definition`` () =
Expand Down
5 changes: 0 additions & 5 deletions ...s/FSharp.Compiler.ComponentTests/Conformance/DelegateTypes/invalid_delegate_definition.fs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ....Compiler.ComponentTests/Conformance/DelegateTypes/invalid_delegate_definition.fs.err.bsl
View file
Open in desktop

This file was deleted.