Skip to content

fix metadata failure due to double integration of signature #14189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix metadata failure due to double integration of signature #14189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf4d5b
fix metadata failure due to double duplication
dsyme Oct 27, 2022
790e3c6
fix metadata failure due to double duplication
dsyme Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions src/Compiler/Driver/ParseAndCheckInputs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,26 +1159,6 @@ let AddCheckResultsToTcState

ccuSigForFile, tcState

let AddDummyCheckResultsToTcState
(
tcGlobals,
amap,
qualName: QualifiedNameOfFile,
prefixPathOpt,
tcSink,
tcState: TcState,
tcStateForImplFile: TcState,
rootSig
) =
let hadSig = true
let emptyImplFile = CreateEmptyDummyImplFile qualName rootSig
let tcEnvAtEnd = tcStateForImplFile.TcEnvFromImpls

let ccuSigForFile, tcState =
AddCheckResultsToTcState (tcGlobals, amap, hadSig, prefixPathOpt, tcSink, tcState.tcsTcImplEnv, qualName, rootSig) tcState

(tcEnvAtEnd, EmptyTopAttrs, Some emptyImplFile, ccuSigForFile), tcState

/// Typecheck a single file (or interactive entry into F# Interactive)
let CheckOneInputAux
(
Expand Down Expand Up @@ -1347,18 +1327,10 @@ let CheckOneInput

match partialResult with
| Choice1Of2 result -> return result, tcState
| Choice2Of2 (amap, _conditionalDefines, rootSig, _priorErrors, file, tcStateForImplFile, _ccuSigForFile) ->
return
AddDummyCheckResultsToTcState(
tcGlobals,
amap,
file.QualifiedName,
prefixPathOpt,
tcSink,
tcState,
tcStateForImplFile,
rootSig
)
| Choice2Of2 (_amap, _conditionalDefines, rootSig, _priorErrors, file, tcStateForImplFile, ccuSigForFile) ->
let emptyImplFile = CreateEmptyDummyImplFile file.QualifiedName rootSig
let tcEnvAtEnd = tcStateForImplFile.TcEnvFromImpls
return (tcEnvAtEnd, EmptyTopAttrs, Some emptyImplFile, ccuSigForFile), tcState
}

// Within a file, equip loggers to locally filter w.r.t. scope pragmas in each input
Expand Down