Skip to content

Parser: recover unfinished match clause at eof #14167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

Parser: recover unfinished match clause at eof #14167

merged 2 commits into from
Oct 26, 2022

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Oct 24, 2022

An fixup for #13985, which changed the recovery rules, and the following match expression wouldn't parse anymore when at EOF:

match () with
| _ -> ()
| _,

Changes error to recover which also covers the EOF case.

@psfinaki
Copy link
Contributor

psfinaki commented Oct 26, 2022

@auduchinok thanks for the fix!

@psfinaki psfinaki merged commit 57ebc9a into dotnet:main Oct 26, 2022
@vzarytovskii vzarytovskii added this to the October-2022 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.5

Projects

F# Compiler and Tooling
Archived in project

Milestone

October-2022

Development

Successfully merging this pull request may close these issues.

5 participants

@auduchinok @psfinaki @0101 @T-Gro @vzarytovskii