Fix build for sbom generation. #14115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that we have been building vsix' twice.
So in order to ensure we are not so wasteful, and to ensure that the arcade team are not struggling with our wasteful build. I have made it a tad more efficient.
O.K - so the above is rubbish:
Microsoft.FSharp.Compiler.slnis essential, and it needs separating from visualfsharp.sln somewhat, because of how and what we insert into the SDK.The issue is that when arcade is building sbom's for the insertion phase (sbom means secure bill of materials) it generates them for each solution build, it performs. Unfortunately it will have already done this for
VisualFSharp.sln, and so when it repeats this forMicrosoft.FSharp.Compiler.slnthis fails because it has already added the sbom's created by the previous solution. The way the sbom tool works is to add a list of files generated by scanning the intermediate output directory for vsix'.The fix presented here disables sbom generation when building
Microsoft.FSharp.Compiler.sln. This is okay becauseMicrosoft.FSharp.Compiler.slnwill never generate a vsix for insertion into VS.