Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 6, 2022

Having the external keyword in the trivia could help us to format code like:

type T() =
  [<DllImport("kernel32.dll")>]
  extern UIntPtr private GetProcessHeap()

T-Gro
T-Gro previously approved these changes Oct 6, 2022
@auduchinok
Copy link
Member

@nojaf Would it be difficult to have a separate union case for extern declarations instead of reusing the let bindings one?

@nojaf
Copy link
Contributor Author

nojaf commented Oct 6, 2022

I was thinking of doing that in a future PR.
I'd first like to see how far I get with this single change.
The union case would need to be in multiple places.

@vzarytovskii vzarytovskii enabled auto-merge (squash) October 6, 2022 14:21
@vzarytovskii vzarytovskii requested a review from T-Gro October 6, 2022 14:21
@vzarytovskii vzarytovskii merged commit 23d9352 into dotnet:main Oct 6, 2022
@nojaf nojaf deleted the extern-trivia branch October 7, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants