Eagerly format exceptions in FSI's interactive scripting API #14026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
force-pushed
the
exception_eager_formatting
branch
2 times, most recently
from
1258f09 to
93c68bd
Compare
KevinRansom
previously approved these changes
Oct 6, 2022
psfinaki
previously approved these changes
Oct 7, 2022
0101
reviewed
Oct 7, 2022
tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs
Outdated
Show resolved
Hide resolved
abonie
force-pushed
the
exception_eager_formatting
branch
from
faa18d7 to
a3e432b
Compare
auto-merge was automatically disabled
October 7, 2022 14:15
Pull request was converted to draft
Eval* methods of FSIEvaluationSession that are using CompilationDiagnosticsLogger are at risk of mutating data that's referred to in the exception before error message is printed. To prevent that, this commit makes CompilationDiagnosticsLogger take additional argument that can control early pre-processing of logged exceptions.
abonie
force-pushed
the
exception_eager_formatting
branch
from
a3e432b to
caf35fd
Compare
Member
Author
psfinaki
approved these changes
Oct 7, 2022
0101
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eager formatting of exceptions to CompilationDiagnosticLogger (which accumulates exceptions in an array) in FsiEvaluationSession.
This should fix #13921 which was due to the fact, that type variables contained in ValueRestriction exception were mutated before diagnostics were committed.
Not sure whether this same approach should be used wider or not.