Adding parser support for N-d arrays up to rank 32 #13991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
requested review from
0101,
KevinRansom,
abonie,
dsyme,
psfinaki and
vzarytovskii
0101
previously approved these changes
Sep 27, 2022
tests/FSharp.Compiler.ComponentTests/Language/MultiDimensionalArrayTests.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/Language/MultiDimensionalArrayTests.fs
Outdated
Show resolved
Hide resolved
Member
Author
|
@dsyme can I merge this? |
0101
approved these changes
Oct 6, 2022
psfinaki
approved these changes
Oct 6, 2022
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Feel free to ignore all the nitpicking - great job :)
tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/Language/MultiDimensionalArrayTests.fs
Show resolved
Hide resolved
Contributor
|
@vzarytovskii I guess this could have gone under a language version switch (though no real need to add now), and should count as an F# 7.0 feature. @T-Gro Could you add a very very short RFC under https://github.com/fsharp/fslang-design/tree/main/FSharp-7.0 please? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the parser to support definition of types for multidimensional arrays.
Until now, only backtick syntax (e.g. int
[,,,,]) was supported.Within this PR, backticks are no longer needed.
[,,,,]Are the same type and are all supported.
The limitation of max. rank 32 is inherited by the limitation of System.Array, and the compiler will not allow int[.. 32 or more commas] as a type.