Skip to content

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Sep 22, 2022

Fixes op_Range symbol in FCS has non synthetic range that covers the whole for expression. In other similar cases the produced ranges are synthetic.

let _ = seq {
    for _ = 0 to 5 do yield! []
}

Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@T-Gro T-Gro requested a review from dsyme October 17, 2022 08:02
T-Gro
T-Gro previously approved these changes Oct 17, 2022
@dsyme
Copy link
Contributor

dsyme commented Oct 17, 2022

@auduchinok I'll mark as approved (though it's possible me changes to your PR will cause tests to fail...)

@T-Gro T-Gro enabled auto-merge (squash) October 17, 2022 13:49
auto-merge was automatically disabled October 17, 2022 17:27

Base branch requires signed commits

@auduchinok auduchinok closed this Oct 19, 2022
@auduchinok auduchinok reopened this Oct 19, 2022
@vzarytovskii vzarytovskii enabled auto-merge (squash) October 19, 2022 10:00
@vzarytovskii vzarytovskii merged commit 7d842a5 into dotnet:main Oct 21, 2022
@auduchinok auduchinok deleted the opRangeSynthetic branch October 21, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants