Skip to content

Enable binlog in source-build bootstrap run. #13931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Enable binlog in source-build bootstrap run. #13931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa1402
Enable binlog in source-build bootstrap run.
crummel Sep 19, 2022
9c51ee3
Add comments on how this works.
crummel Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion eng/SourceBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,15 @@
DependsOnTargets="PrepareInnerSourceBuildRepoRoot"
BeforeTargets="RunInnerSourceBuildCommand">

<!-- this runs the source-build bootstrap path as described in https://github.com/dotnet/fsharp/blob/95df49e380ea8dbf33653fa4209f89dba29413f5/eng/build.sh#L247
Note that we *are not* passing -source-build here so we do this bootstrap build in the outer build.
the important parts here are:
-bootstrap will build the "Proto" config of F# which includes tools and a bootstrap compiler
-skipBuild skips the rest of the build
-bl enables the binlogs for the tools and Proto builds, which make debugging failures here easier
-->
<Exec
Command="./build.sh --bootstrap --skipBuild"
Command="./build.sh --bootstrap --skipBuild -bl"
WorkingDirectory="$(InnerSourceBuildRepoRoot)"
EnvironmentVariables="@(InnerBuildEnv);DotNetBuildFromSource=true" />
</Target>
Expand Down