Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 9, 2022

Related to #12119 (comment)

@dsyme I formatted some more files.
I've also expanded all glob patterns, this would allow for any new files in that folder to be formatted from day one.

Oh, and I updated to beta-009 which had a fix for fsprojects/fantomas#2289, so some other files are impacted by that as well.

@dsyme
Copy link
Contributor

dsyme commented Sep 9, 2022

We should probably wait until #13737 is in as the conflicts here will be intense (I know we can pre-format that code to match the new settings, but probably easy just to wait for a merge

@nojaf
Copy link
Contributor Author

nojaf commented Sep 9, 2022

@vzarytovskii could you add 5.0.0-beta-009 to the feed please?

@vzarytovskii
Copy link
Member

@vzarytovskii Vlad Zarytovskii FTE could you add 5.0.0-beta-009 to the feed please?

Yep, made a request.

@vzarytovskii
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nojaf
Copy link
Contributor Author

nojaf commented Sep 9, 2022

Thanks!

@dsyme
Copy link
Contributor

dsyme commented Sep 23, 2022

@nojaf OK now #13737 is in can you re-run the fantomas formatting on this? Thanks

I guess we'll get conflicts with #13721

@nojaf
Copy link
Contributor Author

nojaf commented Sep 23, 2022

@dsyme, sure I can pick that up next week.
@vzarytovskii could you add 5.0.2 to the feed?

@vzarytovskii
Copy link
Member

@dsyme, sure I can pick that up next week.
@vzarytovskii could you add 5.0.2 to the feed?

Sure, likely gonna be added on Monday

@nojaf
Copy link
Contributor Author

nojaf commented Oct 3, 2022

@dsyme I've expanded the glob patterns in the ignore file and updated Fantomas to the latest stable version. I would include new files in future PRs.

@vzarytovskii could you add 5.0.3, please?

@vzarytovskii
Copy link
Member

@nojaf

@vzarytovskii could you add 5.0.3, please?

Created the request, will restart CI once it is there.

@vzarytovskii
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - especially good to have all new files checked by default now that exclusions are explicit.

@T-Gro T-Gro requested a review from vzarytovskii October 6, 2022 08:29
@T-Gro T-Gro enabled auto-merge (squash) October 6, 2022 18:01
@nojaf
Copy link
Contributor Author

nojaf commented Oct 10, 2022

Hi @vzarytovskii, all good for you?

@vzarytovskii
Copy link
Member

Hi @vzarytovskii, all good for you?

Sure, should be auto merged once green. Thanks!

@nojaf
Copy link
Contributor Author

nojaf commented Oct 10, 2022

Oh, I'm asking because of
image

I think I still need your explicit approval.

@T-Gro
Copy link
Member

T-Gro commented Oct 10, 2022

Oh, I'm asking because of image

I think I still need your explicit approval.

Should be good now, just the conversations had to be resolved. (I also marked the one from @auduchinok as resolved as I think this PR still deserves to go in)
Now only waiting for CI checks and its merged automatically.

@T-Gro T-Gro merged commit 67f9ccf into dotnet:main Oct 10, 2022
@nojaf nojaf deleted the more-fantomas branch October 10, 2022 14:51
@dsyme
Copy link
Contributor

dsyme commented Oct 27, 2022

Great work here, would love to see continued incremental work on applying fantomas to all code files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants