-
Notifications
You must be signed in to change notification settings - Fork 832
More fantomas #13867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fantomas #13867
Conversation
|
We should probably wait until #13737 is in as the conflicts here will be intense (I know we can pre-format that code to match the new settings, but probably easy just to wait for a merge |
|
@vzarytovskii could you add |
Yep, made a request. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Thanks! |
|
@dsyme, sure I can pick that up next week. |
Sure, likely gonna be added on Monday |
|
@dsyme I've expanded the glob patterns in the ignore file and updated Fantomas to the latest stable version. I would include new files in future PRs. @vzarytovskii could you add |
Created the request, will restart CI once it is there. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work - especially good to have all new files checked by default now that exclusions are explicit.
|
Hi @vzarytovskii, all good for you? |
Sure, should be auto merged once green. Thanks! |
Should be good now, just the conversations had to be resolved. (I also marked the one from @auduchinok as resolved as I think this PR still deserves to go in) |
|
Great work here, would love to see continued incremental work on applying fantomas to all code files. |

Related to #12119 (comment)
@dsyme I formatted some more files.
I've also expanded all glob patterns, this would allow for any new files in that folder to be formatted from day one.
Oh, and I updated to beta-009 which had a fix for fsprojects/fantomas#2289, so some other files are impacted by that as well.