fix 12761 #13865
Merged
fix 12761 #13865
+99
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is ready |
vzarytovskii
approved these changes
Sep 9, 2022
Member
|
/backport to release/dev17.3 |
Contributor
|
Started backporting to release/dev17.3: https://github.com/dotnet/fsharp/actions/runs/3471354086 |
Contributor
|
@vzarytovskii backporting to release/dev17.3 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
vzarytovskii
pushed a commit
to vzarytovskii/fsharp
that referenced
this pull request
Nov 15, 2022
vzarytovskii
added a commit
that referenced
this pull request
Nov 15, 2022
Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12761 - a problem with generic
backgroundTaskand any resumable state machine that has an AfterAction involving closures that capture generic parameters only via the struct state machine type.The root cause was that the free variable computation for closures was not taking into account that there is a template substitution that may reveal more free type variables.