Skip to content

Optimize IntrinsicFunctions.getTypeInfo. #13858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Optimize IntrinsicFunctions.getTypeInfo. #13858

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db98c94
Optimize `IntrinsicFunctions.getTypeInfo`.
teo-tsirpanis Sep 7, 2022
f2c46a5
Merge branch 'main' into gettypeinfo-opt
dsyme Sep 23, 2022
dd0dd11
Merge branch 'main' into gettypeinfo-opt
T-Gro Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/FSharp.Core/prim-types.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,20 +601,19 @@ namespace Microsoft.FSharp.Core
// duplicated from above since we're using integers in this section
let CompilationRepresentationFlags_PermitNull = 8

let getTypeInfo (ty:Type) =
if ty.IsValueType
let private getTypeInfo<'T> =
if typeof<'T>.IsValueType
then TypeNullnessSemantics_NullNever else
let mappingAttrs = ty.GetCustomAttributes(typeof<CompilationMappingAttribute>, false)
if mappingAttrs.Length = 0
if not (typeof<'T>.IsDefined(typeof<CompilationMappingAttribute>, false))
then TypeNullnessSemantics_NullIsExtraValue
elif ty.Equals(typeof<unit>) then
elif typeof<'T>.Equals(typeof<unit>) then
TypeNullnessSemantics_NullTrueValue
elif typeof<Delegate>.IsAssignableFrom(ty) then
elif typeof<Delegate>.IsAssignableFrom(typeof<'T>) then
TypeNullnessSemantics_NullIsExtraValue
elif ty.GetCustomAttributes(typeof<AllowNullLiteralAttribute>, false).Length > 0 then
elif typeof<'T>.IsDefined(typeof<AllowNullLiteralAttribute>, false) then
TypeNullnessSemantics_NullIsExtraValue
else
let reprAttrs = ty.GetCustomAttributes(typeof<CompilationRepresentationAttribute>, false)
let reprAttrs = typeof<'T>.GetCustomAttributes(typeof<CompilationRepresentationAttribute>, false)
if reprAttrs.Length = 0 then
TypeNullnessSemantics_NullNotLiked
else
Expand All @@ -627,7 +626,7 @@ namespace Microsoft.FSharp.Core

type TypeInfo<'T>() =
// Compute an on-demand per-instantiation static field
static let info = getTypeInfo typeof<'T>
static let info = getTypeInfo<'T>

// Publish the results of that computation
static member TypeInfo = info
Expand Down