Return None when Trivia is missing for Ident in SynLongIdent. #13847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Sep 6, 2022
nojaf
commented
Sep 15, 2022
dsyme
approved these changes
Sep 16, 2022
auduchinok
approved these changes
Sep 19, 2022
|
I am getting an error running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat fixes #13842.
@auduchinok can you give some more examples where the trivia list is smaller than the ident list?
I would personally like to address all these cases when the SynLongIdent is created.
The partial fix I've added to
member this.IdentsWithTriviadoesn't feel right.These lists should in theory never be out of sync. Even when recovery is kicking in.