Symbols: add more APIs #13824
Merged
Symbols: add more APIs #13824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
reviewed
Sep 1, 2022
auduchinok
changed the title
auduchinok
force-pushed
the
symbols-basicQualifiedName
branch
from
ecaeaa5 to
e0b96b7
Compare
Member
Author
|
This is ready. |
dsyme
reviewed
Sep 23, 2022
dsyme
reviewed
Sep 23, 2022
dsyme
reviewed
Sep 23, 2022
T-Gro
reviewed
Oct 21, 2022
T-Gro
reviewed
Oct 21, 2022
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
Contributor
|
@T-Gro I tried to accept your changes but github is all confused You should be able to push changes directly to the branch? Please do that, and let's get this green and in |
T-Gro
reviewed
Nov 2, 2022
tests/FSharp.Compiler.Service.Tests/FSharp.CompilerService.SurfaceArea.netstandard.expected
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 2, 2022
tests/FSharp.Compiler.Service.Tests/FSharp.CompilerService.SurfaceArea.netstandard.expected
Outdated
Show resolved
Hide resolved
Member
Author
|
Hey, sorry for not updating the PR earlier, I've had some local issues with FCS solution recently. I can update the needed things if CI is not green after this run |
T-Gro
approved these changes
Nov 3, 2022
Member
|
Checks passing, please approve. |
Contributor
|
@dsyme please reapprove |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some APIs to FSharpEntity and FSharpType types that we've been using in our FCS fork.