Rework to ctrl+C to match updated apis #13770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vzarytovskii
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread abort feature in the clr apis, have now gone through approval.
This pr, updates our use of them to match the modified APIs.
I cannot explain why CheckExpressions has a white space change. It came when I ran fantomas so there.
To run we have to wait until, the net7 rc makes it into vs.
Or install the rc net sdk, build this change, and copy built files and then run it.
The abort happens when the clr chooses to allow, so cancel will often continue to process for a short while, until the clr is ready to abort the thread.