Added tests for fsc help and version options #13765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Aug 23, 2022
dsyme
reviewed
Aug 23, 2022
dsyme
reviewed
Aug 23, 2022
dsyme
reviewed
Aug 23, 2022
dsyme
requested changes
Aug 23, 2022
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Just a few comments. Good to be beginning to unit test at this level.
…o psfinaki/13748
dsyme
reviewed
Aug 24, 2022
dsyme
reviewed
Aug 24, 2022
dsyme
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13750
First I wanted to do #13748 but then I realized it's very hard to test whatever is going on in the current state of the code. At the same time this is quite an important code part.
So this pulls out some dependencies in order to be able to test the output for
fsc --helpandfsc --version.Functionality is not changed, just refactoring and tests.