Skip to content

Desugar SynMemberDefns of SynExceptionDefn before type checking. #13664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Desugar SynMemberDefns of SynExceptionDefn before type checking. #13664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Compiler/Checking/CheckDeclarations.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4635,7 +4635,8 @@ let rec TcModuleOrNamespaceElementNonMutRec (cenv: cenv) parent typeNames scopem
let env = MutRecBindingChecking.TcModuleAbbrevDecl cenv scopem env (id, p, m)
return ([], [], []), env, env

| SynModuleDecl.Exception (edef, m) ->
| SynModuleDecl.Exception (SynExceptionDefn(exnRepr, withKeyword, ms, mExDefn), m) ->
let edef = SynExceptionDefn(exnRepr, withKeyword, desugarGetSetMembers ms, mExDefn)
let binds, decl, env = TcExceptionDeclarations.TcExnDefn cenv env parent (edef, scopem)
let defn = TMDefRec(true, [], [decl], binds |> List.map ModuleOrNamespaceBinding.Binding, m)
return ([defn], [], []), env, env
Expand Down
13 changes: 13 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/TypeChecks/CheckDeclarationsTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,19 @@ namespace FSharpTest
type Tree =
| Empty
| Children of Tree
"""
|> compile
|> shouldSucceed
|> ignore

[<Fact>]
let ``CheckingExceptionDeclarations - SynMemberDefn.GetSetMember`` () =
FSharp """
namespace FSharpTest

exception CustomException of details: string
with
member self.Details with get (): string = self.details
"""
|> compile
|> shouldSucceed
Expand Down