-
Notifications
You must be signed in to change notification settings - Fork 831
Adding ValRepInfoForDisplay for quick info for functions defined in expressions #13488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@auduchinok please also take a look, for some reason cannot request a review from you. |
| do | ||
| let fu$$nc x = () | ||
| () | ||
| """>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really prefer putting the test case source code in the attribute. It's not the end of the world though.
|
@psfinaki Could It could probably be good to add some tests for |
Done. :)
It's likely because I'm not in the dotnet organization, but feel free to ping me, I'm happy to take a look or to help where possible. |
I think do this in a separate PR - this is partly a learning exercise for @psfinaki and will be good to get the specific improvement in the bag. I don't think there will be any downsides to doing it but might be tricky to make sure it doesn't have other effects. |
|
@KevinRansom @auduchinok alright, so I'll merge this and will do a followup for your suggestions. |
|
Oh @psfinaki great work! This was such a nag in tools for a long time, glad you figured it out 🙂 Another thing to try out here would be manual testing with the Signature Help feature when calling a function. That feature relies on having parameters and parameter names and making them available in the tooltips. |
|
Thanks @cartermp :) |
|
@psfinaki It's in SignatureHelp.fs. Btw, it has examples of how |
|
@psfinaki let me know if you have any troubles with it. I can hopefully remember some context on why some of the weird stuff is the way it is |
|
@auduchinok @cartermp thank you both :) |
|
@psfinaki Hi, are you still going to work on |
|
@auduchinok not right now for sure, this has fallen out of my radar :) |
fixes #7080
So this address the final set of cases with let binding tooltips, like this one:
