Refactor get/set members to SynMemberDefn.GetSetMember. #13420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dsyme ready for review! |
dsyme
reviewed
Jul 3, 2022
| None | ||
| #endif | ||
| ) | ||
| |> Seq.map (fun mb -> |
Contributor
There was a problem hiding this comment.
Great to see this code get simpler!
dsyme
reviewed
Jul 3, 2022
|
|
||
| | SynMemberDefn.GetSetMember (getBinding, setBinding, m, _) -> | ||
| (Option.map (fun b -> SynMemberDefn.Member(b, m)) | ||
| >> Option.iter (parseSynMemberDefn objectModelRange)) |
Contributor
There was a problem hiding this comment.
I'll change this to use pipelining
dsyme
approved these changes
Jul 3, 2022
dsyme
reviewed
Jul 4, 2022
|
|
||
| match parseResults.ParseTree with | ||
| | Members(SynMemberDefn.Member(range = range; memberDefn = SynBinding(xmlDoc = xmlDoc) as binding) :: _) -> | ||
| | Members([ SynMemberDefn.GetSetMember(Some (SynBinding(xmlDoc = xmlDoc) as binding), _, range, _); _ ]) -> |
Contributor
There was a problem hiding this comment.
It feels like we could do with a test for the XML doc. Looking at the errors expected for this test, the XML doc will get placed on each of the bindings, probably duplicated, it is not shared. I guess this is ok for now - and I know this is really orthogonal to the PR, but it would be good to pin down current behaviour and work out how we can improve the syntax tree
dsyme
reviewed
Jul 4, 2022
tests/FSharp.Compiler.ComponentTests/Conformance/ClassTypes/GetSetMembers/GetSetMembers.fs
Show resolved
Hide resolved
This was referenced Jul 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13273.