Skip to content

Parser: fix unfinished tuple range #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

Parser: fix unfinished tuple range #13402

merged 1 commit into from
Jun 30, 2022

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Jun 28, 2022

  • Unifies unfinished tuple expr error ranges across recovery rules
  • Strips ranges to only include comma at the end, so subsequent nodes or whitespace ranges are not included into expression range (i.e. prevents some range could be included in two disjoint nodes)
  • Cleans up the rules

@dsyme dsyme merged commit 03a4329 into dotnet:main Jun 30, 2022
@auduchinok auduchinok mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@auduchinok @dsyme