Add OutputRefAssembly and RefOnly to the FSC task #13263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jun 8, 2022
Contributor
|
You can mark it as ready if you like. |
Contributor
Author
|
@KevinRansom Thanks for the review, feel free to merge. |
marcin-krystianc
added a commit
to marcin-krystianc/sdk
that referenced
this pull request
Jul 1, 2022
Generation of reference assemblies for F# was disabled previously (dotnet#13085) because the F# compiler didn't support them. Now both, the F# compiler (dotnet/fsharp#12334) and the FCS task (dotnet/fsharp#13263) support reference assemblies. Also, the bug around the copying of F# ref assemblies was fixed (dotnet/fsharp#13266) so it is time to enable the generation of ref assemblies for F#.
marcin-krystianc
pushed a commit
to marcin-krystianc/sdk
that referenced
this pull request
Jul 1, 2022
Generation of reference assemblies for F# was disabled previously (dotnet#13085) because the F# compiler didn't support them. Now both, the F# compiler (dotnet/fsharp#12334) and the FCS task (dotnet/fsharp#13263) support reference assemblies. Also, the bug around the copying of F# ref assemblies was fixed (dotnet/fsharp#13266) so it is time to enable the generation of ref assemblies for F#.
marcin-krystianc
added a commit
to marcin-krystianc/sdk
that referenced
this pull request
Jul 1, 2022
Generation of reference assemblies for F# was disabled previously (dotnet#13085) because the F# compiler didn't support them. Now both, the F# compiler (dotnet/fsharp#12334) and the FCS task (dotnet/fsharp#13263) support reference assemblies. Also, the bug around the copying of F# ref assemblies was fixed (dotnet/fsharp#13266) so it is time to enable the generation of ref assemblies for F#.s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step toward resolving the #13223.
It adds new parameters to the FSC task to match Roslyn's CSC task (See OutputRefAssembly and RefOnly).
I've tested manually that after this change, it is possible to use
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>in a project to generate reference assembly. Note that until #13216 is resolved, build optimization based on ref assemblies will not yet work.