In keyword trivia #12673
Merged
In keyword trivia #12673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Jan 31, 2022
nojaf
force-pushed
the
in-keyword-trivia
branch
from
09aedaa to
da4a9c3
Compare
KevinRansom
approved these changes
Jan 31, 2022
Contributor
|
Thanks for taking care of this Kevin |
nojaf
commented
Feb 2, 2022
| { (fun _ m -> ()) } | ||
| { let mToken = rhs parseState 1 | ||
| // In LexFilter.fs the IN token could have been transformed to an ODECLEND one. | ||
| let mIn = if (mToken.EndColumn - mToken.StartColumn) = 2 then Some mToken else None |
Contributor
Author
There was a problem hiding this comment.
@dsyme I just discovered that this little hack doesn't work with:
do
let e1 = e :?> Collections.DictionaryEntry
e1.Key, e1.ValueBecause e1 has the same length as in the check fall apart.
Any other check I can implement to detect that the token was replaced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #12631 and fixes #10198.
There is one questionable change in
hardwhiteDefnBindingsTerminator:where I'm using a check to see ifINbecame anODECLEND. I'm not sure how bulletproof that check is.Please review @dsyme.
Many thanks.