Skip to content

UnmanagedCallersOnlyAttribute is unsupported #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2021
Merged

UnmanagedCallersOnlyAttribute is unsupported #12350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a24a4fd
UnmanagedCallersOnlyAttribute is unsupported
Happypig375 Nov 6, 2021
6a4b58d
Update TcGlobals.fs
Happypig375 Nov 14, 2021
6f85058
Update TcGlobals.fs
Happypig375 Nov 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/fsharp/TcGlobals.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,12 @@ type public TcGlobals(compilingFslib: bool, ilg:ILGlobals, fslibCcu: CcuThunk, d
| true, builder -> builder tinst
| _ -> TType_app (tcref, tinst)

// Adding an unnecessary "let" instead of inlining into a muiti-line pipelined compute-once "member val" that is too complex for @dsyme
let v_attribs_Unsupported = [
tryFindSysAttrib "System.Runtime.CompilerServices.ModuleInitializerAttribute"
tryFindSysAttrib "System.Runtime.CompilerServices.CallerArgumentExpressionAttribute"
tryFindSysAttrib "System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute"
] |> List.choose (Option.map (fun x -> x.TyconRef))

override x.ToString() = "<TcGlobals>"
member _.ilg=ilg
Expand Down Expand Up @@ -1224,10 +1230,7 @@ type public TcGlobals(compilingFslib: bool, ilg:ILGlobals, fslibCcu: CcuThunk, d
member val attrib_CallerFilePathAttribute = findSysAttrib "System.Runtime.CompilerServices.CallerFilePathAttribute"
member val attrib_CallerMemberNameAttribute = findSysAttrib "System.Runtime.CompilerServices.CallerMemberNameAttribute"
member val attrib_SkipLocalsInitAttribute = findSysAttrib "System.Runtime.CompilerServices.SkipLocalsInitAttribute"
member val attribs_Unsupported = [
tryFindSysAttrib "System.Runtime.CompilerServices.ModuleInitializerAttribute"
tryFindSysAttrib "System.Runtime.CompilerServices.CallerArgumentExpressionAttribute"
] |> List.choose (Option.map (fun x -> x.TyconRef))
member val attribs_Unsupported = v_attribs_Unsupported

member val attrib_ProjectionParameterAttribute = mk_MFCore_attrib "ProjectionParameterAttribute"
member val attrib_CustomOperationAttribute = mk_MFCore_attrib "CustomOperationAttribute"
Expand Down