Better error message when abstract member impl is wrong

[forki]

fixes #1203

[forki]

[forki]

This one is ready for review.

[dsyme]

This can be Lists.existsSquared

[KevinRansom]

I think the error message does not really make clear why the additional parenthesis is needed perhaps this:

The member 'Function' expects a tupled argument.  The required signature is 'member IInterface.Function : (int32 * int32) -> unit.  A Member function uses parenthesis' and commas to indicate sequential arguments.  Use additional parenthesis' to indicate the argument is tupled.  E.g.
        member this.Function ( (i, j) )

[forki]

@KevinRansom the issue is that we can't really decide if the implementation is wrong or someone already did a wrong interface definition

[KevinRansom]

@forki the interface exists and is what is being implemented, so it can be assumed to be correct and thus the implementation must be at fault by not specifying a tuple. My real point is that the revised error message didn't really explain why the extra parenthesis' is needed.

[forki]

In the reported case the interface contained the bug. But I understand what
you mean
On Jun 24, 2016 4:49 PM, "Kevin Ransom (msft)" [email protected]
wrote:

@forki https://github.com/forki the interface exists and is what is
being implemented, so it can be assumed to be correct and thus the
implementation must be at fault by not specifying a tuple. My real point is
that the revised error message didn't really explain why the extra
parenthesis' is needed.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1229 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNJq-sWL2Ejr79hSBncI0Fx2sDteWks5qO-6EgaJpZM4IqX-q
.

[cartermp]

the issue is that we can't really decide if the implementation is wrong or someone already did a wrong interface definition

We should bias towards the interface as-written to be intended here.

[dsyme]

@forki Please fix merge conflicts when you get the chance, thanks

[forki]

done. but these were non-trivial so we better wait for green.

[forki]

ok good. seems to work

[dsyme]

All green apart from AppVeyor, which is taking a while to catch up