VS Navigation consolidation #12105
Merged
VS Navigation consolidation #12105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is great! |
cartermp
reviewed
Sep 8, 2021
| match gtdTask.Result.Value with | ||
| | FSharpGoToDefinitionResult.NavigableItem(navItem), _ -> | ||
| gtd.NavigateToItem(navItem, statusBar) | ||
| // 'true' means do it, like Sheev Palpatine would want us to. |
cartermp
reviewed
Sep 8, 2021
| true | ||
| | FSharpGoToDefinitionResult.ExternalAssembly(targetSymbolUse, metadataReferences), _ -> | ||
| gtd.NavigateToExternalDeclaration(targetSymbolUse, metadataReferences, cancellationToken, statusBar) | ||
| // 'true' means do it, like Sheev Palpatine would want us to. |
cartermp
reviewed
Sep 8, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
More a nit about calling this navigation. We also have a FSharpNavigateToSearchService that is technically a form of navigation, but has nothing to do with navigating to the definition of a symbol.
Contributor
Author
|
This is ready |
dsyme
approved these changes
Nov 15, 2021
Contributor
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several ways to do navigation in VS, but a lot of it was spread out. This PR aims to consolidate it into a single type
FSharpNavigation.We have some quirks between quick-info and go-to-definition such as if one doesn't work the other one will? The goal was to address that, but it turns out it's going to be a bit more involved because the different navigation calls are catered to their respective VS feature. We will need to address that part in a separate PR.