Skip to content

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Aug 4, 2021

I've been experimenting with reporting more expression types and discovered that completion may fail when an unresolved qualifier expression type is reported, like here:

module Module =
    let x = 1

Module.{caret}

This PR moves the qualifiers check so it happens after filtering bad types. Let's see if there's anything that may get fixed or broken with this change.

@auduchinok
Copy link
Member Author

Cool, all is green. One less problem to solve when continuing to work on #8828.

@TIHan TIHan merged commit 6f7e2a0 into dotnet:main Aug 4, 2021
@auduchinok auduchinok deleted the getExprType-getQualifiers branch August 5, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants