Skip to content

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Jun 4, 2021

Bump SDK to 5.0.300 (+corresponding runtime), fixes #11610, adds test to check that SynConst.SourceIdentifier is recognized as valid static argument to a provided type.

@vzarytovskii vzarytovskii changed the title Test if #11610 also breaks any of our tests on 5.0.300 Fix for #11610 + bump SDK to 5.0.300 Jun 7, 2021
@vzarytovskii vzarytovskii marked this pull request as ready for review June 7, 2021 13:00
@vzarytovskii vzarytovskii requested review from TIHan and cartermp June 7, 2021 13:01
@vzarytovskii vzarytovskii enabled auto-merge (squash) June 7, 2021 13:23
@cartermp
Copy link
Contributor

cartermp commented Jun 7, 2021

Does this also address having #I __SOURCE_DIRECTORY__ at the top of a script?

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Jun 7, 2021

Does this also address having #I __SOURCE_DIRECTORY__ at the top of a script?

I'm not sure that's the same issue, this one only fixes the source identifiers as static arguments.
Let me check.

@vzarytovskii vzarytovskii merged commit 78826fd into dotnet:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on SDK 5.0.300: When using an identifier like __SOURCE_DIRECTORY__ in a type parameter one get FS3045 compilation error.

3 participants