Skip to content

skip flaky tests #11587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021
Merged

skip flaky tests #11587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,9 @@ type AsyncModule() =
| e -> Assert.Fail(sprintf "Unexpected error %A" e)
}
Async.RunSynchronously test

[<Fact>]

// test is flaky: https://github.com/dotnet/fsharp/issues/11586
//[<Fact>]
member this.``OnCancel.RaceBetweenCancellationHandlerAndDisposingHandlerRegistration``() =
let test() =
use flag = new ManualResetEvent(false)
Expand All @@ -296,7 +297,8 @@ type AsyncModule() =

for _i = 1 to 300 do test()

[<Fact>]
// test is flaky: https://github.com/dotnet/fsharp/issues/11586
//[<Fact>]
member this.``OnCancel.RaceBetweenCancellationAndDispose``() =
let flag = ref 0
let cts = new System.Threading.CancellationTokenSource()
Expand All @@ -314,7 +316,8 @@ type AsyncModule() =
:? System.OperationCanceledException -> ()
Assert.AreEqual(1, !flag)

[<Fact>]
// test is flaky: https://github.com/dotnet/fsharp/issues/11586
//[<Fact>]
member this.``OnCancel.CancelThatWasSignalledBeforeRunningTheComputation``() =
let test() =
let cts = new System.Threading.CancellationTokenSource()
Expand Down