-
Notifications
You must be signed in to change notification settings - Fork 832
Simplify FCS SurfaceAreaTest test #11574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify FCS SurfaceAreaTest test #11574
Conversation
…to the expected one, which can then be diffed. I just moved the contents, there is no change in the surface area. Hopefully green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be extending IFileSystem with actual file read/write functionality.
There is StreamExtensions type in the FileSystem.FS which will allow you to do the same (FileSystem.OpenFileForWrite(path).Write(contents)).
|
@vzarytovskii makes sense and done. There is only one downside I see with raw This may be improved by having extensions to IFileSystem that would deal with it, taking a Since this is going to be used in all tooling, turning the API this way (for some use cases at least) would reduce concern for tooling on top of FCS to misuse the resources the concrete implementation returns. |
|
Green. |
|
Bump |
|
Hey @Happypig375, not sure this is a priority for being merged. I like the change because it skips recompiles but it is not a big deal and probably not urgent for the maintainers to adjust it (also, conficting files now, so can't be merged as is). I had the pending PR with init properties which is more important that I intended to update based off this, but I can also unblock it by manually adjusting the surface area .fs file there. |
|
@smoothdeveloper Sorry it took so long. I've fixed the build + merged the main. If it looks ok to you, going to merge once green. |
|
@vzarytovskii thanks! it looks green & good to me. |
by generating the actual file next to the expected one, which can then be diffed.
I just moved the contents, there is no change in the surface area. Hopefully green.