Skip to content

Conversation

@smoothdeveloper
Copy link
Contributor

This is my experimental branch for https://github.com/fsharp/fslang-design/blob/master/drafts/FS-1095-requirenamedargumentattribute.md.

Mostly to get feedback from CI, and maybe getting patches & reviews along the line.

@runfoapp runfoapp bot mentioned this pull request Apr 5, 2021
@smoothdeveloper smoothdeveloper force-pushed the argument-names-enforced branch 2 times, most recently from 7543112 to 2b08d9c Compare April 17, 2021 11:48
@NinoFloris
Copy link
Contributor

I do like this as an optional thing!

@smoothdeveloper
Copy link
Contributor Author

@cartermp, can you confirm this one also goes behind language version flag and should ship in preview?

What is the bar for using language version guards?

If that process is solidified, it would be good to describe it in the README.md of fslang-design repository.

@vzarytovskii vzarytovskii marked this pull request as draft September 6, 2022 17:28
@psfinaki
Copy link
Contributor

psfinaki commented Dec 8, 2022

Hey @smoothdeveloper, this PR has a frightening number of conflicts - do you still want to continue working on this?
If so, we might want to set up a small meeting with a few F# devs to decide what to do here as this seems like quite a big thing.

@vzarytovskii
Copy link
Member

vzarytovskii commented Dec 8, 2022

What is the bar for using language version guards?

I'm slightly late to the party, usually all breaking changes (often, even if they are fixes) go under the language flag, and I think that all new features should too. If we don't, it defeats the whole purpose of language versions.

Ideally subset of features for specific language version should not change with time, so people will be sure that by using specific version they'll get specific behaviour.

can you confirm this one also goes behind language version flag and should ship in preview?

So, I would say - yes.

@KevinRansom
Copy link
Contributor

@smoothdeveloper , hey mate,
Thanks for this contribution it looks as though it has hit a bump, and so, I am going to close it, please reopen this if you still want to complete this and get some time to work on it.

Once again thanks

Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants