Skip to content

Fix IL creation parts became internal #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2021
Merged

Fix IL creation parts became internal #11354

merged 2 commits into from
Apr 3, 2021

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Apr 2, 2021

This fixes some of the IL* types needed for IAssemblyReader became internal during the namespaces revamp and couldn't be accessed anymore.

@auduchinok auduchinok closed this Apr 2, 2021
@auduchinok auduchinok reopened this Apr 2, 2021
@runfoapp runfoapp bot mentioned this pull request Apr 2, 2021
Closed
@cartermp cartermp requested a review from dsyme April 2, 2021 15:40
@KevinRansom
Copy link
Contributor

KevinRansom commented Apr 2, 2021

@auduchinok ,
These look like they should be public.

Thanks for this.

Kevin

KevinRansom
KevinRansom approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cartermp cartermp merged commit 0841bba into dotnet:main Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@dsyme dsyme Awaiting requested review from dsyme

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok @KevinRansom @vzarytovskii @cartermp