Skip to content

Conversation

@cartermp
Copy link
Contributor

fixes #11317

image

@smoothdeveloper
Copy link
Contributor

Does it address the seemingly non deterministic order as well?

@cartermp
Copy link
Contributor Author

Not that I'm aware of, but we'll find out :)

@cartermp
Copy link
Contributor Author

There's probably a much fancier way to separate string-based names/search keys and the presentation.

I experimented with taking string tokens from the data we compete and assigning an appropriate TaggedText for each "part" and rendering it all fancy-like. But that ended up being a little more difficult, and represents some feature creep when this solves the main issue at hand. So I decided not to bother with going that route right now. Might come in as a secondary PR if I'm feeling up for it some evening or weekend.

@smoothdeveloper
Copy link
Contributor

@cartermp, this fixes the main issue that @kerams brought and that's honestly, outstanding turnaround.

I think once the results disambiguated, living with the nondeterministic order is more bearable, and concur with your reply to scope later/with other things.

I was trying to figure out if you stoned all the birds without groking the code changes myself 🙂

@TIHan TIHan merged commit d823b21 into dotnet:main Mar 31, 2021
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differentiate between signature and implementation files in Go to All results

3 participants