Add 'RemoveUnusedBinding' code fixer #11289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
Mar 21, 2021
baronfel
added a commit
to baronfel/FsAutoComplete
that referenced
this pull request
Mar 22, 2021
Contributor
Author
|
This is ready for review |
TIHan
reviewed
Mar 31, 2021
| let! sourceText = document.GetTextAsync(context.CancellationToken) | ||
|
|
||
| let! parsingOptions, _ = projectInfoManager.TryGetOptionsForEditingDocumentOrProject(document, context.CancellationToken, userOpName) | ||
| let! parseResults = checker.ParseFile(document.FilePath, sourceText.ToFSharpSourceText(), parsingOptions, userOpName = userOpName) |> liftAsync |
Contributor
There was a problem hiding this comment.
I recommend to use ParseDocument instead of ParseFile.
ParseFile is fine, but lately we've been consolidating parsing and checking documents through extensions to the FSharpChecker, which ParseDocument is one of those extensions.
TIHan
approved these changes
Mar 31, 2021
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
This looks good to me, one minor comment about ParseFile.
Contributor
Author
|
I'll merge this in and do a PR for this and several other code fixers that use ParseFile. |
Contributor
Author
|
Opened #11337 |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local bindings:
Function bindings:
It won't trigger where it shouldn't.