Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 3, 2021

This fixes #11176

There was a simple transcription mistake in #11151

Will and I are discussing the exact scenario and if it's worth adding a test for it. But for now we should just get this fix into main

@cartermp
Copy link
Contributor

cartermp commented Mar 3, 2021

@dsyme conflicts.

@dsyme
Copy link
Contributor Author

dsyme commented Mar 3, 2021

This is ready. We have another transient test failure however, in the same test, this time on Linux

Ok, passed 100 tests.
The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at [email protected](ExceptionDispatchInfo edi)
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 104
   at Microsoft.FSharp.Control.AsyncPrimitives.continuation@951-2(AsyncActivation`1 ctxt, Boolean useCcontForTaskCancellation, Task completedTask) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 952
   at Microsoft.FSharp.Control.AsyncPrimitives.taskContinueWithUnit(Task task, AsyncActivation`1 ctxt, Boolean useCcontForTaskCancellation) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 966
   at <StartupCode$FSharp-Core>[email protected](AsyncActivation`1 ctxt) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 1708
   at Microsoft.FSharp.Control.AsyncPrimitives.ProtectedCode[T](AsyncActivation`1 ctxt, FSharpFunc`2 userCode) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 453
   at <StartupCode$FSharp-Core>[email protected](AsyncActivation`1 ctxt) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 1690
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 104
   at <StartupCode$FSharp-Core>[email protected](Object o) in /home/vsts/work/1/s/src/fsharp/FSharp.Core/async.fs:line 157
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

@dsyme dsyme closed this Mar 3, 2021
@dsyme dsyme reopened this Mar 3, 2021
@cartermp cartermp merged commit e6e04ac into dotnet:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in IDE checking using VIsualFSharp.sln on main

4 participants