Parallel parsing - fsc.exe #11140
Merged
Parallel parsing - fsc.exe #11140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Feb 23, 2021
cartermp
approved these changes
Feb 26, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks great subject to tests passing!
cartermp
approved these changes
Feb 26, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks great subject to tests passing!
5 tasks
Contributor
Author
|
Almost passing, one test is failing as the order of errors have changed. Will need to investigate. |
Contributor
Author
|
It passes! |
Contributor
Author
|
@dsyme, this look ok to you? |
vzarytovskii
approved these changes
Feb 26, 2021
dsyme
reviewed
Mar 1, 2021
…o commit delayed diagnostics
dsyme
approved these changes
Mar 3, 2021
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables parallel parsing by default when compiling via fsc.exe. Is a continuation of #10208 and is ready.
This adds a new test compiler option:
-test:ParallelOff- turns off concurrent buildEarly results
CPU: Core i7-10700K @ 3.8GHz (8 cores, 16 logical cores)
Using command line
msbuild FSharp.Compiler.Service.fsprojwith only compiling netstandard2.0 target - this is also without generating the parserTime Elapsed 00:00:38.65Time Elapsed 00:00:34.90That's a ~9% decrease in compile time when re-building the compiler service.