Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 5, 2021

fixes #10808

Several things were actually wrong here, but this corrects everything as far as I can tell. In summary:

  • Don't go hunting for method parameter help as a means to see if we should go down that path; instead base it off the trigger character and if the adjusted column (relative to the caret position) in source is also a character indicating we're inside a method call
  • Account for the fact that a CE is itself an application, so when we check if we're in one, account for this case, lest we erroneously attribute the application of async { ...} as a relevant function application
  • Add some testeronies

@cartermp cartermp merged commit 45948f1 into dotnet:main Jan 5, 2021
@cartermp cartermp deleted the sighelp1 branch January 5, 2021 17:47
@cartermp cartermp restored the sighelp1 branch January 7, 2021 01:03
cartermp added a commit to cartermp/fsharp that referenced this pull request Jan 7, 2021
@cartermp cartermp deleted the sighelp1 branch January 7, 2021 01:15
@KevinRansom
Copy link
Contributor

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signature Help doesn't trigger for function applications inside of a computation expression

3 participants